Re: I want to work against Bug 44522 - Upload limit 2G
Hi,
On Thu, 2013-06-27 at 10:21 +0200, Ralf Lang wrote:
> Hi,
>
> I want to deal with Bug 44522 which disallows uploads > 2G
> https://bugs.php.net/bug.php?id=44522&edit=1
Great!
> Today with PHP cloud solutions, we are running into more situations
> where this really hurts.
Yay cloud :-D
(i don't see why cloud matters, here though it's more about modern
bandwidth and storage space)
> Before I begin providing a github patch (as I have no php svn access and
> I don't think it's needed) against master and possibly 5.5.next:
>
> Does anybody know of intricate reasons why the existing patch
>
> https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest
>
> could not be included into php 5.5?
Most likely since nobody cared enough and pushed it. (both, pushed in
the tree and pushed as in making people aware)
Unfortunately the patch can't make it in 5.5. It changes the size and
offsets in the sapi globals which breaks binary compatibility which we
can't do in a dot release. Has to be 5.6/PHP.next.
I haven't looked close enough to comment on the patch itself.
johannes
Thread (23 messages)