Re: I want to work against Bug 44522 - Upload limit 2G
Hey:
Instead of change the uint to long or size_t, Maybe make the
max_file_upload_size 0 means unlimited? like Apached did, ulimited or
<= 2Gb
https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestbody
thanks
On Thu, Jun 27, 2013 at 4:21 PM, Ralf Lang <[email protected]> wrote:
> Hi,
>
> I want to deal with Bug 44522 which disallows uploads > 2G
> https://bugs.php.net/bug.php?id=44522&edit=1
>
> Today with PHP cloud solutions, we are running into more situations
> where this really hurts.
>
> Before I begin providing a github patch (as I have no php svn access and
> I don't think it's needed) against master and possibly 5.5.next:
>
> Does anybody know of intricate reasons why the existing patch
>
> https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest
>
> could not be included into php 5.5?
>
> Or is it only what stas said in 2012:
>
> "The patch however
> needs to be cleaned up (no IGNORE vars, etc.) and changing signature for
> zend_atoi may not be safe if any code out there presumes it returns int
> (integer
> overflow). Also, no reason to use signed long there where we used
> unsigned long."
>
> This would be my first patch against php core. Any pointers apreciated.
>
>
> --
> Ralf Lang
> Linux Consultant / Developer
> Tel.: +49-170-6381563
> Mail: [email protected]
> B1 Systems GmbH
> Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
> GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
>
--
Laruence Xinchen Hui
http://www.laruence.com/
Thread (23 messages)