[PATCH] Constification of some PHP API calls

From:	Andrey Hristov	Date:	Mon, 29 Jul 2013 10:01:20 +0000
Subject:	[PATCH] Constification of some PHP API calls
Groups:	php.internals
Request:	Send a blank email to [email protected] to get a copy of this message

 Hi,
after experiencing again warnings about conversion from const char * to char * when calling some PHP API functions I decided to spend some time and constify a few of these. The result is a patch that constifies the Streams API, and few functions in Zend and TSRM (to which I have no karma). Most of the changes are conversion of "char *" to "const char *" parameters, where applicable. In a few places string lengths are changed from int to size_t. Few functions return now "const char *" instead of "char *" (the caller did not modify/release these before).

The patch is against php-src because it changes API which can be only done in a new version.

Opinions?

Best,
Andrey


Attachment: [text/x-patch] php_api_constify.patch

   

Thread (6 messages)

• Andrey HristovMon, 29 Jul 2013 10:01:20 +0000
  • Julien PauliMon, 29 Jul 2013 14:35:22 +0000
  • Sara GolemonTue, 30 Jul 2013 22:55:47 +0000
    • Andrey HristovWed, 31 Jul 2013 08:35:05 +0000
      • Sara GolemonWed, 31 Jul 2013 14:56:17 +0000
        • Andrey HristovWed, 31 Jul 2013 15:29:18 +0000