Re: [PATCH] Constification of some PHP API calls
On Mon, Jul 29, 2013 at 12:01 PM, Andrey Hristov <[email protected]> wrote:
> Hi,
> after experiencing again warnings about conversion from const char * to
> char * when calling some PHP API functions I decided to spend some time and
> constify a few of these. The result is a patch that constifies the Streams
> API, and few functions in Zend and TSRM (to which I have no karma). Most of
> the changes are conversion of "char *" to "const char *" parameters, where
> applicable. In a few places string lengths are changed from int to size_t.
> Few functions return now "const char *" instead of "char *" (the caller did
> not modify/release these before).
>
> The patch is against php-src because it changes API which can be only done
> in a new version.
>
> Opinions?
>
I'm +1.
About strings sizes from int to size_t , you perhaps could sync with
Anthony who worked hard recently on such changes, especially regarding zval
string type.
Julien.Pauli
Thread (6 messages)