Re: session_regenerate_id(true) by default

From: Date: Tue, 22 Oct 2013 11:23:02 +0000
Subject: Re: session_regenerate_id(true) by default
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Am 22.10.2013 13:16 schrieb "Ferenc Kovacs" <[email protected]>:
>
> On Tue, Oct 22, 2013 at 1:10 PM, Patrick Schaaf <[email protected]> wrote:
>>
>> BTW and a bit off-topic: is there a good reason for session_write_close
not returning a success indicator? Right now it spams the log with a
misleading message, but gives me no chance (short of setting up a global
error handler to catch and handle that message) to see (and maybe retry /
use a fallback) on failure
>
> you could do @session_write_close() and error_get_last() instead of the
global handler,

Oh, thanks, that's less of a pain.

> but I think that it is a good idea and would be a trivial and backward
compatible change.

Good. I'm on vacation this week, but will try to cook up a PR when I'm back
next week. About time I start to work on php-src instead of only making
remarks here :)  Do you think this would need an RFC?

best regards
  Patrick


Thread (20 messages)

« previous php.internals (#69761) next »