Re: session_regenerate_id(true) by default

From: Date: Tue, 29 Oct 2013 10:44:08 +0000
Subject: Re: session_regenerate_id(true) by default
References: 1  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi all,

On Tue, Oct 22, 2013 at 3:53 PM, Yasuo Ohgaki <[email protected]> wrote:

> Hi all,
>
> Without 'true', session_regenerate_id() will not delete old session data
> which may contain sensitive data. It was made to 'false' by default for
> users relying on the bug. (PHP 4.x, IIRC)
>
> Almost all users should call session_regenerate_id() with 'true'
> parameter. Therefore, I would like to suggest make it 'true' by default
> from next PHP.
>
> Any comments?
>

I've created RFC for this.

https://wiki.php.net/rfc/session_regenerate_id

I think Rowan's proposal is the best, so this RFC proposes to raise
E_DEPRECATED error.

On Wed, Oct 23, 2013 at 8:55 PM, Rowan Collins <[email protected]>
 wrote:

> So raise an E_DEPRECATED if you don't pass the parameter, and document
> that passing true will normally be the desired behavior. Then in some
> future major version, remove the default value, making it an E_ERROR or
> whatever to omit it.


If there are any more comment, I'll appreciate it.

Regards,

--
Yasuo Ohgaki
[email protected]


Thread (20 messages)

« previous php.internals (#69932) next »