On Mon, Jan 27, 2014 at 7:18 AM, Yasuo Ohgaki <[email protected]> wrote:
> On Mon, Jan 27, 2014 at 5:15 AM, Stas Malyshev <[email protected]>wrote:
>
>> > Typical configuration works, but it's better to be resolved soon bugs.
>> > I don't have much time now, so I hope someone has time to take care...
>>
>> Well, we can not merge a patch that segfaults. So until this is fixed,
>> that patch is a no go.
>
>
> The patch is not causing segfaults.
>
> Zend engine is segfaulting for zend_multibyte tests.
> It's a separate issue. You'll see segfaults in 5.4 and up without
> my patch.
>
> I've merged zend_multibyte tests fixes already. That's the reason why you
> see failing tests on 5.4 and up.
>
> It's a different issue and if nobody is willing to fix. I'll fix
> zend_multibyte
> next month.
>
For the record, I committed this patch to 5.4 and up.
As you can see, the patch is simply re-enabled tests for 5.4 and up.
(Note: there is no mbstring.script_encoding INI for 5.4 and up. It's
removed.)
The segfaults of zend engine are irrelevant for this proposal.
commit e769c96a1102f33e5783c35b7a7eedf5d81be7b9
Author: Yasuo Ohgaki <[email protected]>
Date: Sun Jan 19 13:28:48 2014 +0900
Enable zend.multibyte tests. Tipcal configuration works, but most tests
fail.
diff --git a/ext/mbstring/tests/zend_multibyte-01.phpt
b/ext/mbstring/tests/zend_multibyte-01.phpt
index d96e0f0..f2403ab 100644
--- a/ext/mbstring/tests/zend_multibyte-01.phpt
+++ b/ext/mbstring/tests/zend_multibyte-01.phpt
@@ -1,14 +1,9 @@
--TEST--
zend multibyte (1)
--SKIPIF--
-<?php
-ini_set("mbstring.script_encoding","SJIS");
-if (ini_set("mbstring.script_encoding","SJIS") != "SJIS") {
- die("skip zend-multibyte is not available");
-}
-?>
--INI--
-mbstring.script_encoding=Shift_JIS
+zend.multibyte=On
+zend.script_encoding=Shift_JIS
mbstring.internal_encoding=Shift_JIS
--FILE--
<?php
--
Yasuo Ohgaki
[email protected]