Re: Re: [VOTE] Default character encoding

From: Date: Sun, 26 Jan 2014 22:42:39 +0000
Subject: Re: Re: [VOTE] Default character encoding
References: 1 2 3 4 5 6 7 8 9  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi Stas,

On Mon, Jan 27, 2014 at 7:35 AM, Stas Malyshev <[email protected]>wrote:

> > For the record, I committed this patch to 5.4 and up.
>
> You seem to be talking about different patch. The patch I am talking
> about is https://github.com/php/php-src/pull/568, it was
> not committed
> anywhere (and definitely not in 5.4 as it is targeted to be in 5.6) and
> Travis shows segfaults on it (see
> https://travis-ci.org/php/php-src/builds/17247814)
> which are not it
> regular master Travis tests.
>
> > The segfaults of zend engine are irrelevant for this proposal.
>
> I disagree, segfaults caused by the patch are very relevant.


I fetched and merged changes from original php-src into my fork.
I shouldn't have done that :(

I'm guessing that's the reason why we see failed tests.
Finding out what's wrong now. Just a moment.
It takes time for rebuild and full tests.

Regards,

--
Yasuo Ohgaki
[email protected]


Thread (29 messages)

« previous php.internals (#71611) next »