On Mon, Mar 17, 2014 at 5:45 PM, David Soria Parra <[email protected]> wrote:
>
> have you been testing this with a json testing library like
> https://code.google.com/p/json-test-suite/ ?
>
Not yet. I will definitely have a look.
>
> I really like your project, but we have to be very very careful when it
> comes to json adn make sure it supports everything the current json lib
> supports.
>
>
I agree with you 100%. Currently it passes all ext/json tests that should
cover lots of cases but definitely need to do more testing.
Thanks
Jakub
On Mon, Mar 17, 2014 at 5:45 PM, David Soria Parra <[email protected]> wrote:
> Jakub Zelenka <[email protected]> schrieb:
> > --001a11330a7413861304f4aa17a7
> > Content-Type: text/plain; charset=ISO-8859-1
> >
> > On Fri, Mar 14, 2014 at 8:36 AM, Remi Collet <[email protected]>
> wrote:
> >
> >>
> >> Can you pull all the test suite from official ext/json to check if it is
> >> a dropin alternative ?
> >
> >
> > Done! ;) I just renamed json to jsond. All tests pass for me. Just one
> skip
> > for 32bit test (pass001.1.phpt) but it's 64bit variant is fine. If
> someone
> > could try that test, that would be great.
> >
> > It's tested only with PHP master branch and apparently not compile under
> > 5.5. I will have a look on older PHP versions and fix it later. Also need
> > to improve build and do more benchmarking.
> >
> > Any testing, ideas and comments will be appreciated... ;)
> >
> > Thanks
> >
> > Jakub
> >
> > --001a11330a7413861304f4aa17a7--
>
> have you been testing this with a json testing library like
> https://code.google.com/p/json-test-suite/ ?
>
> I really like your project, but we have to be very very careful when it
> comes to json adn make sure it supports everything the current json lib
> supports.
>
> -David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>