Re: Merge PR 621

From: Date: Thu, 20 Mar 2014 01:13:24 +0000
Subject: Re: Merge PR 621
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi Stas,

> On 20 Mar, 2014, at 9:04 am, Stas Malyshev <[email protected]> wrote:
> 
> Hi!
> 
>> https://github.com/php/php-src/pull/621
>> 
>> It makes isset() and empty() call offsetGet() on objects that extend
>> ArrayObject if offsetExists() returns TRUE.
> 
> Looks at this patch, isn't that what check_empty parameter was supposed
> to be doing? Why doesn't it work and it needs to be moved to opcodes?

Yes, that's probably what it was supposed to do, but as you can see from bug 66834 that's
clearly not the case. I had earlier approached the problem purely from SPL standpoint (see linked
PR) but Etienne said that it would be a better idea to tackle this issue further up the chain so to
speak :)

> 
> -- 
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227


Thread (23 messages)

« previous php.internals (#73312) next »