Hi Stas,
On Fri, Mar 21, 2014 at 10:48 AM, Tjerk Meesters
<[email protected]>wrote:
> Hi Stas,
>
> On Fri, Mar 21, 2014 at 9:11 AM, Stas Malyshev <[email protected]>wrote:
>
>> Hi!
>>
>> > It seems that PR 614 covers exactly that; it uses the check_empty flag
>> > within spl_array_has_dimension_ex() to make sure offsetGet() is called
>> > when needed.
>>
>> I understand that the problem may be that check_empty is not sent on
>> isset? Didn't verify that though.
>>
>
> It does, as can be seen here:
>
> http://lxr.php.net/xref/PHP_5_6/Zend/zend_vm_def.h#4737
>
> The check_empty argument value is ternary, meaning it can be 0 (isset), 1
> (empty) or 2 (key exists).
>
> Having looked it over I realized that my older patch had some issues; I've
> addressed those and reopened #614.
>
Do you have any issues with the code as it stands now?
https://github.com/php/php-src/pull/614
It's currently targeted at 5.4; if there are any objections to that I'll
move the changes to 5.6 instead.
>
> I've closed #621.
>
>
>> --
>> Stanislav Malyshev, Software Architect
>> SugarCRM: http://www.sugarcrm.com/
>> (408)454-6900 ext. 227
>>
>
>
>
> --
> --
> Tjerk
>
--
--
Tjerk