Uvision exporter fixes for Python 3, CPM updates, and Windows path issues #10045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to encode() was causing the include paths to be placed in the uvision product file with the prefix "b'" and the postfix "'". This broke the parsing of this file and broke the build.
mbed_config.h is a file that is placed in your project root when you export. This allows the configuration to be used by your IDE. When this file already exists (due to a previous export), it changed the compiler include option on Windows from "-include mbed_config.h" to "-include .\mbed_config.h". The "\" character was interpreted as an escape character "\m" and broke the build. This converts all resource paths to use the Posix path separator "/" before writing project files to avoid this issue.
bridadan
changed the title
|
@bridadan, thank you for your changes. |
theotherjimmy
approved these changes
Mar 12, 2019
0xc0170
approved these changes
Mar 13, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
|
possible license failure, restarting CI |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit 1920212 fixes https://os.mbed.com/questions/84249/Keil-Compile-issue-After-CLI-export/
The rest of the commits were fixes I found while developing #10021. However because that is a feature addition, I'm not sure when that PR will come in. I thought the fixes were more important so I decided to put these up in a separate PR.
Pull request type
Reviewers
@theotherjimmy
Release Notes