Skip to content

Fix uvision6 python export #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix uvision6 python export #10320

wants to merge 1 commit into from

Conversation

j3hill
Copy link
Contributor

@j3hill j3hill commented Apr 4, 2019 •
edited
Loading

Description

The mbed-os tools Python uVision export script ("-i uvision6") is not implementing the correct path in the resulting project settings. Add "win_to_unix()" to Python export script to address this.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@j3hill j3hill requested a review from theotherjimmy April 4, 2019 16:06
@ciarmcom ciarmcom requested review from a team April 4, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 4, 2019

@j3hill, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2019

The mbed-os tools Python uVision export script ("-i uvision6") is not implementing the correct path in the resulting project settings.

Does it lead to failures or this is cosmetic change? how to reproduce?

@bridadan
Copy link
Contributor

bridadan commented Apr 5, 2019

@j3hill Pretty sure I fixed this issue in this PR: #10045.

Is this confirmed broken on master branch still?

@cmonr cmonr requested review from a team and removed request for a team April 8, 2019 19:21
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

Is this confirmed broken on master branch still?

@j3hill Can you retest please?

@j3hill
Copy link
Contributor Author

j3hill commented Apr 11, 2019

I have confirmed that this issue was fixed in this PR: #10045. Closing this PR.

@j3hill j3hill closed this Apr 11, 2019
@sg- sg- removed the needs: review label Apr 11, 2019
@j3hill j3hill deleted the uVExp branch April 11, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

1 more reviewer

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@j3hill @ciarmcom @0xc0170 @bridadan @OPpuolitaival @sg-