Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Apkawa/pytest-image-diff
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Apkawa/pytest-image-diff
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: PR2_xpath
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 9 files changed
  • 2 contributors

Commits on Mar 15, 2022

  1. feat: allow xpath for test regression against element + Windows support 

    Warning: This patch does two things, which I sadly didn't have time to split out into separate PRs.

1) Allow a user to give an optional `xpath` qualifier when calling `screenshot_regression`. The regression will then be tested against this single element instead of the whole page.
2) Make pytest-image-diff with splinter work properly on Windows (see issue #1). Since Windows requires us to close the temp file first, we make the temp file persistent, close it, and then tells splinter to write to it. Afterwards we clean up the temporary file before returning from the function.
    @matslindh
    matslindh committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    031f4fb View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. add windows os

    @Apkawa
    Apkawa committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    68fcfb8 View commit details
    Browse the repository at this point in the history

  2. try fix ci

    @Apkawa
    Apkawa committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    674c06a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from matslindh/add-xpath-to-screenshot-regressi… 

    …on-and-windows-compatibility-fix

feat: allow xpath for test regression against element + Windows support
    @Apkawa
    Apkawa authored Mar 16, 2022
    Configuration menu
    Copy the full SHA
    80b9b17 View commit details
    Browse the repository at this point in the history

  4. Fix compatibles for windows, latest chrome; add test for xpath

    @Apkawa
    Apkawa committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    244fe30 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. try fix splinter windows test; drop chromedriver-binary from [splinter]

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    75fe4e0 View commit details
    Browse the repository at this point in the history

  2. fix ci

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    35070f2 View commit details
    Browse the repository at this point in the history

  3. pin chrome and chromedriver versions

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    fc10ba5 View commit details
    Browse the repository at this point in the history

  4. try pin chrome

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    3856c3f View commit details
    Browse the repository at this point in the history

  5. fix chrome win version number

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    5e6848c View commit details
    Browse the repository at this point in the history

  6. disable support selenium-windows, bruh

    @Apkawa
    Apkawa committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7f6e37b View commit details
    Browse the repository at this point in the history
Loading