Fork Netty's Cookie Decoder, close #283

[slandelle]

@rlubke IMHO, you should extract GrizzlyResponse.convertCookies so that GrizzlyAsyncHttpProvider.newRequest can use the same GrizzlyCookie <-> AHCCookie conversion logic, based on CookiesBuilder.ServerCookiesBuilder.

[rlubke]

Thanks, I'll take a look.

Stephane Landelle mailto:[email protected]
April 24, 2013 3:15 PM

@rlubke https://github.com/rlubke IMHO, you should extract
GrizzlyResponse.convertCookies so that
GrizzlyAsyncHttpProvider.newRequest can use the same GrizzlyCookie <->
AHCCookie conversion logic, based on CookiesBuilder.ServerCookiesBuilder.

---

    You can merge this Pull Request by running

git pull https://github.com/AsyncHttpClient/async-http-client
netty-cookie-decoder

Or view, comment on, or merge it at:

#285

    Commit Summary

• Fork Netty's Cookie Decoder, close Handle double quoted cookie values #283

  File Changes
  

• M pom.xml
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-0
  (1)

• M src/main/java/com/ning/http/client/Cookie.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-1
  (203)

• M
  src/main/java/com/ning/http/client/providers/apache/ApacheResponse.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-2
  (7)

• M
  src/main/java/com/ning/http/client/providers/grizzly/GrizzlyAsyncHttpProvider.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-3
  (7)

• M
  src/main/java/com/ning/http/client/providers/jdk/JDKResponse.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-4
  (6)

• M
  src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-5
  (13)

• M
  src/main/java/com/ning/http/client/providers/netty/NettyResponse.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-6
  (6)

• M src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-7
  (60)

• A
  src/main/java/com/ning/org/jboss/netty/handler/codec/http/CookieDecoder.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-8
  (304)

• A
  src/main/java/com/ning/org/jboss/netty/handler/codec/http/CookieHeaderNames.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-9
  (57)

• A
  src/main/java/com/ning/org/jboss/netty/util/internal/StringUtil.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-10
  (73)

• A
  src/test/java/com/ning/org/jboss/netty/handler/codec/http/CookieDecoderTest.java
  https://github.com/AsyncHttpClient/async-http-client/pull/285/files#diff-11
  (52)

  Patch Links:
  

• https://github.com/AsyncHttpClient/async-http-client/pull/285.patch

• https://github.com/AsyncHttpClient/async-http-client/pull/285.diff