Rename replace() to replaceWith() since Java 1.8 introduces Map.replace() #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerdriesselmann Could you please squash your 3 commits into a single one? |
|
I tried, but did succeed only partially, as there are now two more commits : D However, this one contains all fixes in one commit: gerdriesselmann@f5736c1 Its the one labeled "Java 8 Compatibility Fixes" |
|
Ha ha ha ha. |
|
closed by 8f53b1f |
|
ported on master in b8e0c46 |
|
Thanks @gerdriesselmann |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
* Fix crash if connection is closed very early If the channel is closed before flatMap is executed, all ChannelHandler are removed and `TLSEventsHandler` is therefore not present either. We need to tolerate this even though it is very rare. Testing ideas welcome. Fixes AsyncHttpClient#670 * drop precondition to assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 1.8 brings Map[K, V].replace(), declared as V replace(K key, V value).
This collides with replace declared on FluentCaseInsensitiveStringsMap and FluentStringsMap, which return the self type.
I therefore renamed the functions to replaceWith().
Alternative would be to change signature to return V and override Map's replace(), which however should not work on Java 6 and 7, I guess.