samples(spanner): PITR samples backup fix #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the earliest version time of the database, uses the current time (from spanner). If we used the earliest version time of the database instead we would be creating an empty backup, since the database we are backing up is not 1 hour old (default version retention period).
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
thiagotnunes
changed the title
This reverts commit 5d4bc29.
DateTime does not support nanoseconds, so we have to truncate the timestamp to microseconds.
larkee
reviewed
Mar 2, 2021
spanner/src/create_backup.php
Outdated
| $instance = $spanner->instance($instanceId); | ||
| $database = $instance->database($databaseId); | ||
|
|
||
| $results = $database->execute("SELECT TIMESTAMP_TRUNC(CURRENT_TIMESTAMP(), MICROSECOND) as Timestamp"); |
Contributor
There was a problem hiding this comment.
@jdpedrie The timestamp is being truncated because DateTime does not support nanosecond precision. Is there an alternative that does support nanosecond precision?
thiagotnunes
force-pushed
the
pitr-samples-backup-fix
branch
from
6c89023 to
f10beef
Compare
bshaffer
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the earliest version time of the database, uses the current time (from spanner). If we used the earliest version time of the database instead we would be creating an empty backup, since the database we are backing up is not 1 hour old (default version retention period).