Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spanner/src/create_backup.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,24 @@
* Create a backup.
* Example:
* ```
* create_backup($instanceId, $databaseId, $backupId);
* create_backup($instanceId, $databaseId, $backupId, $versionTime);
* ```
*
* @param string $instanceId The Spanner instance ID.
* @param string $databaseId The Spanner database ID.
* @param string $backupId The Spanner backup ID.
* @param string $versionTime The version of the database to backup.
*/
function create_backup($instanceId, $databaseId, $backupId)
function create_backup($instanceId, $databaseId, $backupId, $versionTime)
{
$spanner = new SpannerClient();
$instance = $spanner->instance($instanceId);
$database = $instance->database($databaseId);

$expireTime = new \DateTime('+14 days');
$versionTime = new \DateTime($database->info()['earliestVersionTime']);
$backup = $instance->backup($backupId);
$operation = $backup->create($database->name(), $expireTime, [
'versionTime' => $versionTime
'versionTime' => new \DateTime($versionTime)
]);

print('Waiting for operation to complete...' . PHP_EOL);
Expand Down
6 changes: 6 additions & 0 deletions spanner/test/spannerBackupTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,15 @@ public function testCancelBackup()
*/
public function testCreateBackup()
{
$database = self::$instance->database(self::$databaseId);
$results = $database->execute("SELECT TIMESTAMP_TRUNC(CURRENT_TIMESTAMP(), MICROSECOND) as Timestamp");
$row = $results->rows()->current();
$versionTime = $row['Timestamp'];

$output = $this->runFunctionSnippet('create_backup', [
self::$databaseId,
self::$backupId,
$versionTime,
]);
$this->assertStringContainsString(self::$backupId, $output);
}
Expand Down