Skip to content

Conversation

@bshaffer
Copy link
Contributor

TODO: add tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge googleapis/google-api-php-client#715 we can remove this line

@bshaffer
Copy link
Contributor Author

This library relies on googleapis/google-api-php-client#712 for the PubSub API calls

@bshaffer
Copy link
Contributor Author

@bshaffer bshaffer force-pushed the add-pubsub branch 5 times, most recently from a7de7f5 to b19f625 Compare October 28, 2015 21:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for the class.

@bshaffer
Copy link
Contributor Author

this might be an overkill sample... there are calls made to datastore which clutter what we're trying to do.

I can split this into two samples - datastore and pubsub - and try to simplify the pubsub part.

@SurferJeffAtGoogle
Copy link
Contributor

It's not clear to me what the app does. I don't know what data is being
stored where and why. An overview in the README.md would help.

On Wed, Oct 28, 2015 at 3:33 PM, Brent Shaffer [email protected]
wrote:

this might be an overkill sample... there are calls made to datastore
which clutter what we're trying to do.

I can split this into two samples - datastore and pubsub - and try to
simplify the pubsub part.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@bshaffer
Copy link
Contributor Author

Plan for this example:

  1. Split into 2 examples - pubsub and datastore
  2. Add pull to the pubsub example
  3. Make pubsub example store messages in memory only, and add note when on appengine that strange behavior may happen across multiple instances.

@bshaffer bshaffer closed this Oct 30, 2015
@SurferJeffAtGoogle
Copy link
Contributor

Could we please not lead users down the wrong path in step 3? Isn't there
another example we could show?

I got really annoyed in the cloud training class when they said "build it
like this. But, of course you could never build a production system like
this."

On Fri, Oct 30, 2015 at 3:38 PM, Brent Shaffer [email protected]
wrote:

Plan for this example:

  1. Split into 2 examples - pubsub and datastore
  2. Add pull to the pubsub example
  3. Make pubsub example store messages in memory only, and add note
    when on appengine that strange behavior may happen across multiple
    instances.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@bshaffer
Copy link
Contributor Author

bshaffer commented Nov 3, 2015

@SurferJeffAtGoogle That's not the same IMHO - we aren't building production software for the users, we are building simple examples. Our samples shouldn't be opinionated in implementation detail that varies for each application.

@bshaffer bshaffer mentioned this pull request Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants