-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds PubSub example for PHP #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge googleapis/google-api-php-client#715 we can remove this line
|
This library relies on googleapis/google-api-php-client#712 for the PubSub API calls |
a7de7f5 to
b19f625
Compare
pubsub/src/DatastoreHelper.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for the class.
|
this might be an overkill sample... there are calls made to I can split this into two samples - datastore and pubsub - and try to simplify the pubsub part. |
|
It's not clear to me what the app does. I don't know what data is being On Wed, Oct 28, 2015 at 3:33 PM, Brent Shaffer [email protected]
|
|
Plan for this example:
|
|
Could we please not lead users down the wrong path in step 3? Isn't there I got really annoyed in the cloud training class when they said "build it On Fri, Oct 30, 2015 at 3:38 PM, Brent Shaffer [email protected]
|
|
@SurferJeffAtGoogle That's not the same IMHO - we aren't building production software for the users, we are building simple examples. Our samples shouldn't be opinionated in implementation detail that varies for each application. |
TODO: add tests