PubSub example for PHP #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hopefully addresses the main concerns of #13 |
Contributor
Author
|
@tmatsuo PTAL also :) |
bshaffer
force-pushed
the
add-pubsub
branch
3 times, most recently
from
205a310 to
6ee4e51
Compare
Contributor
Author
|
bump |
pubsub/src/DatastoreHelper.php
Outdated
Contributor
There was a problem hiding this comment.
The datasetId is usually the same as the project id, right? We should note that in a comment.
bshaffer
force-pushed
the
add-pubsub
branch
4 times, most recently
from
2393248 to
ffaaf04
Compare
Contributor
Author
|
ok @SurferJeffAtGoogle, PTAL |
Contributor
There was a problem hiding this comment.
Is this the same string we call [your-project-id] above? Then we should probably call it YOUR_PROJECT_ID here.
Contributor
Author
There was a problem hiding this comment.
I changed everything to your-project-name instead
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.