Skip to content

fix(compute): lro samples #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 5 commits into from
May 20, 2021
Merged

fix(compute): lro samples #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb15341
Merge branch 'master' of github.com:GoogleCloudPlatform/php-docs-samples
rsamborski May 20, 2021
02b7151
Merge branch 'master' of github.com:GoogleCloudPlatform/php-docs-samples
rsamborski May 20, 2021
4ee6f63
Fixing LRO for compute samples and adding region tag to extract the o…
rsamborski May 20, 2021
c0a6e74
Fixed lint issue
rsamborski May 20, 2021
916602b
Update delete_instance.php
bshaffer May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compute/cloud-client/instances/src/create_instance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
use Google\Cloud\Compute\V1\AttachedDiskInitializeParams;
use Google\Cloud\Compute\V1\Instance;
use Google\Cloud\Compute\V1\NetworkInterface;
use Google\Cloud\Compute\V1\Operation;
use Google\Cloud\Compute\V1\ZoneOperationsClient;

/**
Expand Down Expand Up @@ -80,7 +81,7 @@ function create_instance(
$instancesClient = new InstancesClient();
$operation = $instancesClient->insert($instance, $projectId, $zone);

if ($operation->getStatus() === 'RUNNING') {
if ($operation->getStatus() === Operation\Status::RUNNING) {
// Wait until operation completes
$operationClient = new ZoneOperationsClient();
$operationClient->wait($operation->getName(), $projectId, $zone);
Expand Down
14 changes: 12 additions & 2 deletions compute/cloud-client/instances/src/delete_instance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@

# [START compute_instances_delete]
use Google\Cloud\Compute\V1\InstancesClient;
# [START compute_instances_operation_check]
use Google\Cloud\Compute\V1\Operation;
use Google\Cloud\Compute\V1\ZoneOperationsClient;

# [END compute_instances_operation_check]

/**
* Creates an instance.
* Example:
Expand All @@ -49,11 +53,17 @@ function delete_instance(
$instancesClient = new InstancesClient();
$operation = $instancesClient->delete($instanceName, $projectId, $zone);

if ($operation->getStatus() === 'RUNNING') {
# [START compute_instances_operation_check]
if ($operation->getStatus() === Operation\Status::RUNNING) {
// Wait until operation completes
$operationClient = new ZoneOperationsClient();
$operationClient->wait($operation->getName(), $projectId, $zone);

// Default timeout of 60s is not always enough for operation to finish,
// to avoid an exception we set timeout to 180000 ms = 180 s = 3 minutes
$optionalArgs = ['timeoutMillis' => 180000];
$operationClient->wait($operation->getName(), $projectId, $zone, $optionalArgs);
}
# [END compute_instances_operation_check]

printf('Deleted instance %s' . PHP_EOL, $instanceName);
}
Expand Down