feat(spanner): Added sample for copyBackup #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saranshdhingra
added
api: spanner
google-cla
bot
added
the
cla: yes
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
saranshdhingra
added
the
do not merge
bshaffer
reviewed
Dec 6, 2021
asthamohta
reviewed
Dec 15, 2021
bshaffer
reviewed
Dec 21, 2021
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
Looks great! I'll hold off approval until it's ready to merge and the tests pass.
bshaffer
approved these changes
Dec 30, 2021
Collaborator
Author
|
This should be ready to merge once googleapis/google-cloud-php#4732 is merged and released. |
saranshdhingra
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
saranshdhingra
removed
the
do not merge
vishwarajanand
pushed a commit
to vishwarajanand/php-docs-samples
that referenced
this pull request
Apr 6, 2022
vishwarajanand
added a commit
that referenced
this pull request
Apr 12, 2022
## Goal Implement four samples: ``` storage_print_pubsub_bucket_notification storage_create_bucket_notifications storage_delete_bucket_notification storage_list_bucket_notifications ``` ## Change Summary 1. Added a new sample for `storage_create_bucket_notifications` 2. Added tests for the sample in `BucketNotificationsTest`, will support all `storage_*_bucket_notifications` samples 3. Added pubsub in composer, otherwise a clean test run will fail. ## Tests ``` ➜ storage git:(storage_bucket_notifications) ✗ XDEBUG_MODE=coverage ../testing/vendor/bin/phpunit --verbose -c phpunit.xml.dist test/BucketNotificationsTest.php PHPUnit 8.5.23 by Sebastian Bergmann and contributors. Runtime: PHP 7.4.28 with Xdebug 3.1.2 Configuration: /usr/local/google/home/vishwarajanand/github/php-docs-samples/storage/phpunit.xml.dist .... 4 / 4 (100%) Time: 1.66 minutes, Memory: 14.00 MB OK (4 tests, 7 assertions) Generating code coverage report in Clover XML format ... done [247 ms] ➜ storage git:(storage_bucket_notifications) ``` > Squashed following commits: * untested create bucket notifications sample * Sample for creating notification * Tests ready * nit fix removed redundant null check * Addressing PR comments * Fixed filename to match region tag * nit fix added a new line after print statements * Added new samples * Print notification sample and test * Added tests for delete bucket notifications sample * feat: [Storage] complex upload download samples (#1606) * feat(spanner): sample for copyBackup (#1568) * nit fix linting errors * Fixing indentation in composer.json * nit fix linting errors * nit fix minor indentation issues Co-authored-by: Saransh Dhingra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.