Skip to content

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Apr 4, 2022

Goal

Implement four samples:

storage_print_pubsub_bucket_notification
storage_create_bucket_notifications
storage_delete_bucket_notification
storage_list_bucket_notifications

Change Summary

  1. Added a new sample for storage_create_bucket_notifications
  2. Added tests for the sample in BucketNotificationsTest, will support all storage_*_bucket_notifications samples
  3. Added pubsub in composer, otherwise a clean test run will fail.

Tests

➜  storage git:(storage_bucket_notifications) ✗ XDEBUG_MODE=coverage  ../testing/vendor/bin/phpunit --verbose -c phpunit.xml.dist test/BucketNotificationsTest.php
PHPUnit 8.5.23 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.28 with Xdebug 3.1.2
Configuration: /usr/local/google/home/vishwarajanand/github/php-docs-samples/storage/phpunit.xml.dist


....                                                                4 / 4 (100%)

Time: 1.66 minutes, Memory: 14.00 MB

OK (4 tests, 7 assertions)

Generating code coverage report in Clover XML format ... done [247 ms]
➜  storage git:(storage_bucket_notifications)

@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 4, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 4, 2022
@snippet-bot
Copy link

snippet-bot bot commented Apr 4, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 5, 2022
@vishwarajanand vishwarajanand marked this pull request as ready for review April 5, 2022 13:41
@vishwarajanand vishwarajanand requested a review from a team as a code owner April 5, 2022 13:41
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change, otherwise this looks great!

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor indentation issues, otherwise this looks great

@vishwarajanand vishwarajanand merged commit ffbf1f7 into GoogleCloudPlatform:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants