chore: [Storage] update turbo copy and filenames #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ddelgrosso Hi Denis, We'll need to update the turbo replication code samples for PHP. Turbo replication is not set to default, the replication behavior or recovery point objective (rpo) for the bucket is set to default. Looks like we'll want to update the PHP function name(s) as well (set_turbo_replication_async_turbo=>set_rpo_async_turbo). See proposed changes. Thanks!
@ddelgrosso Hi Denis, We'll need to update the turbo replication code samples for PHP. Turbo replication is not set to default, the replication behavior or recovery point objective (rpo) for the bucket is set to default. Looks like we'll want to update the PHP function name and file name: set_turbo_replication_default=>set_rpo_default See proposed changes. Thanks!
product-auto-label
bot
added
the
samples
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for removing region tag in use.
The end of the violation section. All the stuff below is FYI purposes only. You are about to delete the following sample browser pages.
Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
|
The changes look good to me but I defer to @saranshdhingra or one of the PHP experts. |
bshaffer
changed the title
bshaffer
reviewed
Mar 7, 2022
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
The tests are failing because you didn't update them to match the changes in filenames or the change in copy for the test matching. See TurboReplicationTest.php, they'll need to pass before we can merge this.
Saransh, Updated text in the test file php-docs-samples/storage/test/TurboReplicationTest.php.
Contributor
Author
|
@bshaffer Would you please take a look? Thanks! |
Contributor
|
The tests are still failing. Take a look at the logs! |
Contributor
|
saranshdhingra
previously approved these changes
May 23, 2022
Collaborator
saranshdhingra
left a comment
saranshdhingra
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of the tests :)
saranshdhingra
dismissed
their stale review
Waiting for confirmation on region tag/path changes in https://cloud.google.com/storage/docs/managing-turbo-replication
saranshdhingra
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@saranshdhingra @ddelgrosso1
Thanks for calling out the file names, Saransh!
I've done an audit of file names, function names, section tags, printed lines, and descriptions. Please take a look. These are updates to the turbo replication PHP code samples noted in b/217259317. Thanks!