Skip to content

chore: [Storage] update turbo copy and filenames #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saranshdhingra merged 12 commits into from
May 24, 2022
Merged

chore: [Storage] update turbo copy and filenames #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5e7c66a
Update set_turbo_replication_async_turbo.php
rebecca-pete Jan 31, 2022
e36f955
Update set_turbo_replication_default.php
rebecca-pete Jan 31, 2022
cdfa264
Rename set_turbo_replication_async_turbo.php to set_rpo_async_turbo.php
rebecca-pete Mar 5, 2022
0f02271
Update and rename get_turbo_replication_status.php to get_rpo.php
rebecca-pete Mar 5, 2022
6e3935b
Rename set_turbo_replication_default.php to set_rpo_default.php
rebecca-pete Mar 5, 2022
19057d9
Update create_bucket_turbo_replication.php
rebecca-pete Mar 5, 2022
dc0c1dd
Merge branch 'master' into rebecca-pete-turbo-rep-php-edits-patch-1
bshaffer Mar 7, 2022
cd69a3f
Update TurboReplicationTest.php
rebecca-pete Mar 7, 2022
9a96b51
Merge branch 'master' into rebecca-pete-turbo-rep-php-edits-patch-1
rebecca-pete Mar 7, 2022
9efe192
Merge branch 'master' into rebecca-pete-turbo-rep-php-edits-patch-1
ddelgrosso1 May 19, 2022
210ef6a
fix strings in rpo tests
ddelgrosso1 May 20, 2022
d9f2b3e
remove extra has in set_rpo_async_turbo
ddelgrosso1 May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage/src/create_bucket_turbo_replication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
use Google\Cloud\Storage\StorageClient;

/**
* Create a Cloud Storage Bucket with Turbo Replication set to `ASYNC_TURBO`.
* Create a Cloud Storage bucket with the recovery point objective (RPO) set to `ASYNC_TURBO`.
* The bucket must be a dual-region bucket for this setting to take effect.
*
* @param string $bucketName The name of your Cloud Storage bucket.
Expand All @@ -49,7 +49,7 @@ function create_bucket_turbo_replication($bucketName, $location = 'nam4')
'location' => $location,
'rpo' => $rpo
]);
printf('Bucket with Turbo Replication set to \'ASYNC_TURBO\' created: %s' . PHP_EOL, $bucket->name());
printf('Bucket with recovery point objective (RPO) set to \'ASYNC_TURBO\' created: %s' . PHP_EOL, $bucket->name());
}
# [END storage_create_bucket_turbo_replication]

Expand Down
4 changes: 2 additions & 2 deletions storage/src/get_turbo_replication_status.php → storage/src/get_rpo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
use Google\Cloud\Storage\StorageClient;

/**
* Get the bucket's Turbo Replication(rpo) setting.
* Get the bucket's recovery point objective (RPO) setting.
*
* @param string $bucketName the name of your Cloud Storage bucket.
*/
function get_turbo_replication_status($bucketName)
function get_rpo($bucketName)
{
// $bucketName = 'my-bucket';

Expand Down
4 changes: 2 additions & 2 deletions ...src/set_turbo_replication_async_turbo.php → storage/src/set_rpo_async_turbo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*
* @param string $bucketName the name of your Cloud Storage bucket.
*/
function set_turbo_replication_async_turbo($bucketName)
function set_rpo_async_turbo($bucketName)
{
// $bucketName = 'my-bucket';

Expand All @@ -45,7 +45,7 @@ function set_turbo_replication_async_turbo($bucketName)
]);

printf(
'Turbo Replication has been set to ASYNC_TURBO for %s.' . PHP_EOL,
'The replication behavior or recovery point objective (RPO) has been set to ASYNC_TURBO for %s.' . PHP_EOL,
$bucketName
);
}
Expand Down
6 changes: 3 additions & 3 deletions ...age/src/set_turbo_replication_default.php → storage/src/set_rpo_default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
use Google\Cloud\Storage\StorageClient;

/**
* Set the bucket's Turbo Replication(rpo) setting to `DEFAULT`.
* Set the bucket's replication behavior or recovery point objective (RPO) to `DEFAULT`.
*
* @param string $bucketName the name of your Cloud Storage bucket.
*/
function set_turbo_replication_default($bucketName)
function set_rpo_default($bucketName)
{
// $bucketName = 'my-bucket';

Expand All @@ -46,7 +46,7 @@ function set_turbo_replication_default($bucketName)
]);

printf(
'Turbo Replication has been set to DEFAULT for %s.' . PHP_EOL,
'The replication behavior or recovery point objective (RPO) has been set to DEFAULT for %s.' . PHP_EOL,
$bucketName
);
}
Expand Down
22 changes: 12 additions & 10 deletions storage/test/TurboReplicationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
use PHPUnit\Framework\TestCase;

/**
* Unit tests for Turbo Replication(RPO)
* Unit tests to manage a bucket's recovery point objective (RPO). An RPO value set to `DEFAULT`
* indicates the default replication behavior is applied to the bucket.
* An RPO value set to `ASYNC_TURBO` indicates turbo replication is applied to the bucket.
*/
class TurboReplicationTest extends TestCase
{
Expand Down Expand Up @@ -52,7 +54,7 @@ public function testCreateBucketWithTurboReplication()

$this->assertStringContainsString(
sprintf(
'Bucket with Turbo Replication set to \'ASYNC_TURBO\' created: %s',
'Bucket with recovery point objective (RPO) set to \'ASYNC_TURBO\' created: %s',
self::$bucketName
),
$output
Expand All @@ -63,9 +65,9 @@ public function testCreateBucketWithTurboReplication()
}

/** @depends testCreateBucketWithTurboReplication */
public function testGetTurboReplicationStatus()
public function testGetRpo()
{
$output = self::runFunctionSnippet('get_turbo_replication_status', [
$output = self::runFunctionSnippet('get_rpo', [
self::$bucketName,
]);

Expand All @@ -79,15 +81,15 @@ public function testGetTurboReplicationStatus()
}

/** @depends testCreateBucketWithTurboReplication */
public function testSetTurboReplicationStatusDefault()
public function testSetRpoDefault()
{
$output = self::runFunctionSnippet('set_turbo_replication_default', [
$output = self::runFunctionSnippet('set_rpo_default', [
self::$bucketName,
]);

$this->assertEquals(
sprintf(
'Turbo Replication has been set to DEFAULT for %s.' . PHP_EOL,
'The replication behavior or recovery point objective (RPO) has been set to DEFAULT for %s.' . PHP_EOL,
self::$bucketName
),
$output
Expand All @@ -98,15 +100,15 @@ public function testSetTurboReplicationStatusDefault()
}

/** @depends testCreateBucketWithTurboReplication */
public function testSetTurboReplicationStatusAsyncTurbo()
public function testSetRpoAsyncTurbo()
{
$output = self::runFunctionSnippet('set_turbo_replication_async_turbo', [
$output = self::runFunctionSnippet('set_rpo_async_turbo', [
self::$bucketName,
]);

$this->assertEquals(
sprintf(
'Turbo Replication has been set to ASYNC_TURBO for %s.' . PHP_EOL,
'The replication behavior or recovery point objective (RPO) has been set to ASYNC_TURBO for %s.' . PHP_EOL,
self::$bucketName
),
$output
Expand Down