BigTable Admin Samples

[juan-rael]

No description provided.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[juan-rael]

I signed it!

[googlebot]

CLAs look good, thanks!

[billyjacobson]

Hey Juan,

The code is generally looking pretty clear. There are some format differences that match our standard example. I've commented a bunch of them on the instanceadmin sample, so please apply those changes everywhere.

Also, for PHP we keep each code snippet in its own file for readability and simplicity (see https://github.com/GoogleCloudPlatform/php-docs-samples/tree/dec932a96652fc365c6a4b5ba756427890d9ac89/bigquery/api) For example, the directory structure here will look like
php-docs-samples/bigtable/src/bigtable_check_instance_exists.php
php-docs-samples/bigtable/src/bigtable_create_prod_instance.php
... etc.
Follow one of the files for how to take the CLI args as well (this one contains some CLI args https://github.com/GoogleCloudPlatform/php-docs-samples/blob/dec932a96652fc365c6a4b5ba756427890d9ac89/bigquery/api/src/browse_table.php)

Then the tests can still put each flow into a file as you've done already. But should be places under
bigtable/test/

Please let me know if you have any questions or need clarification on this. I will continue to review the rest of the PR in the meantime as most of this will still be the same once it is moved to individual files.

[billyjacobson]

These are looking really good Juan! Mainly a few cleanups and unused variables. I need to take a look at the tests still, but we should be able to get this submitted soon.

[sduskis]

@juan-rael and @billyjacobson is this ready to go?

[billyjacobson]

Sorry, I've been busy this week. I need to review the tests still, but the samples were looking good. I'll wanna do another quick pass on them though just to see if there's anything else I catch.

…

On Fri, Nov 9, 2018 at 11:47 AM Solomon Duskis ***@***.***> wrote: @juan-rael <https://github.com/juan-rael> and @billyjacobson <https://github.com/billyjacobson> is this ready to go? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#743 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFekT55Rs0aHTKzz1rXLxQfHPQW4sDEvks5utbGYgaJpZM4X8mH8> .

-- *• **Billy Jacobson* *•* Developer Programs Engineer, *• *Google Cloud Developer Relations *•* 111 8th Ave, New York, NY 10011 <https://maps.google.com/?q=111+8th+Ave,+New+York,+NY+10011&entry=gmail&source=g>

[bshaffer]

Running locally on a single project I am still getting quota errors. Is there a way you could conceivably reduce the number of calls?

[juan-rael]

Every test do four or five calls, I can reduce the calls, but need to change the test, right now, the test create a instance, create a table, run the snippet, check in the table/instance and then delete the instance...

…

On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer ***@***.***> wrote: Running locally on a single project I am still getting quota errors. Is there a way you could conceivably reduce the number of calls? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#743 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8> .

[bshaffer]

It would be great to reuse a single instance and table across the tests

…

On Tue, Dec 4, 2018, 16:39 juan-rael ***@***.*** wrote: Every test do I think four or five calls, I can reduce the calls, but need to change the test, right now, the test create a instance, create a table, run the snippet, check in the table/instance and then delete the instance... On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer ***@***.***> wrote: > Running locally on a single project I am still getting quota errors. Is > there a way you could conceivably reduce the number of calls? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #743 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8 > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#743 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGWBS3gE0KzwC1PrzJqHaxuCTDbyddFks5u1xWugaJpZM4X8mH8> .

[juan-rael]

I changed the test to use only three instances, but, right now it create one table for every table test(column, table, list). On Tue, Dec 4, 2018 at 7:51 PM Brent Shaffer <[email protected]> wrote:

…

It would be great to reuse a single instance and table across the tests On Tue, Dec 4, 2018, 16:39 juan-rael ***@***.*** wrote: > Every test do I think four or five calls, I can reduce the calls, but need > to change the test, right now, the test create a instance, create a table, > run the snippet, check in the table/instance and then delete the > instance... > > On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer ***@***.***> > wrote: > > > Running locally on a single project I am still getting quota errors. Is > > there a way you could conceivably reduce the number of calls? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < > #743 (comment) > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8 > > > > . > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > < #743 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAGWBS3gE0KzwC1PrzJqHaxuCTDbyddFks5u1xWugaJpZM4X8mH8 > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#743 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AqBRbRqdm-lZ0pstd1I7oZw_5Q4rcSbmks5u1xh0gaJpZM4X8mH8> .

[sduskis]

@bshaffer: there are table admin constraints on the Cloud Bigtable side on multi-cluster instances. We ran into problems using a single instance. We need to use a different instance for instance admin and table admin to avoid those constraints.

[bshaffer]

@sduskis ok, I understand. But have you not ran into quota limits with your other tests?

The Quota UI does not have a way to apply for a higher quota yet.

[bshaffer]

Added #774 to hopefully address this issue (by providing unique credentials for each CI build).

[bshaffer]

Also getting this error now

1) Google\Cloud\Samples\BigTable\Tests\BigTableTest::testCreateCluster
Google\ApiCore\ApiException: {
    "message": "Cannot create multiple clusters in the same zone.",
    "code": 9,
    "status": "FAILED_PRECONDITION",
    "details": []
}

[juan-rael]

I set another region cluster for that test.

[bshaffer]

I've created a PR that has fixes for these tests (#775), so I'm closing this one