Skip to content

BigTable Admin Samples #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 72 commits into from
Dec 5, 2018
Merged

BigTable Admin Samples #775

bshaffer merged 72 commits into from
Dec 5, 2018

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Dec 5, 2018

Fixes tests for #743

Juan Rael added 30 commits October 26, 2018 12:47
BigTable Admin Samples
dbb8f07
Set some changes to the Google Bigtable Admin Samples
4f63e67
Setting Format of some print functions
ee0faf2
Divided the InstanceAdmin in Snippets Files
d8e963e
InstanceAdmin Test completed
77f3a4a
Divided TableAdmin in Snippets Files & TableAdmin Test completed
22beb1a
Changed the README to set the Snippets
b285266
changed 'Instance' to 'instance'
aabfb4c
All samples on /bigtable/api/src
a45b2d3
Argv in Bigtable samples
070a85d
Move the START tag before the use statements.
adaa040
Split the Table Admin file and create all the test of the snippet files
c276da1
Tested all the snippets
7794250
Admin format
924f96e
Deleting unused variables
866dc61
Removed the comment in clear_instance
0a0299d
Resolved Review
21f92c1
Formatting & Conflict Resolve
8914702
Delete Cluster & Delete Family Conflicts
4e5af77
Creating a Test Sample
c6201e8
Create Cluster
8f12807
Created Test Snippets
18a0ecb
Throwing an exception when the instances is already exists.
5a70628
Delete Instance and Delete Table
6b49ed7
Delete Table
3f75614
Bigtable Update Gc Rule
1017060
UpdateGcRule - CheckRule Function
3b99938
a
9ca0797
create a function for the try/catch
5ef8f5f
Check in Delete Instance and Delete Table
9fa6d12
Juan Rael and others added 15 commits December 4, 2018 18:13
Added Exponential Backoff Trait
c16bd2a
Added try/catch to delete_instance
656bfee
@bshaffer
Merge branch 'bigtable_admin' of https://github.com/juan-rael/php-doc…
d11ea80 
…s-samples into juan-rael-bigtable_admin
Adding TestTrait again
ea45f7f
Changed runSnippet to static
fe17217
Removed the tearDownAfterClass method
6679d99
Changed Test structure, to use less instances
e0782c3
Added Delete Test
b086efc
@bshaffer
Merge branch 'bigtable_admin' of https://github.com/juan-rael/php-doc…
2dd2c73 
…s-samples into juan-rael-bigtable_admin
Resolve errors of typing
ea030c8
create_cluster test setting other region cluster
a02432f
create_cluster test setting other region cluster
9091e2a
@bshaffer
Merge branch 'bigtable_admin' of https://github.com/juan-rael/php-doc…
ba63e00 
…s-samples into juan-rael-bigtable_admin
@bshaffer
fixes bigtable tests
6a8f728
@bshaffer
clean up for code standards
2a74961
@bshaffer bshaffer mentioned this pull request Dec 5, 2018
Closed
@googlebot
Copy link

googlebot commented Dec 5, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@billyjacobson billyjacobson self-requested a review December 5, 2018 22:49
@bshaffer
Copy link
Contributor Author

bshaffer commented Dec 5, 2018

@billyjacobson tests are passing - will you give this guy approval?

@bshaffer
Copy link
Contributor Author

bshaffer commented Dec 5, 2018

@juan-rael want to give this a quick look before I merge it?

billyjacobson
billyjacobson approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@billyjacobson billyjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@juan-rael
Copy link

juan-rael commented Dec 5, 2018

I read it, its ok.

@billyjacobson
Copy link
Member

billyjacobson commented Dec 5, 2018

@juan-rael I think you need to explicitly approve this for the CLA to pass

@billyjacobson billyjacobson reopened this Dec 5, 2018
@bshaffer bshaffer merged commit b616dd7 into master Dec 5, 2018
@bshaffer bshaffer deleted the juan-rael-bigtable_admin branch December 5, 2018 23:22
@juan-rael
Copy link

juan-rael commented Dec 5, 2018 via email

@bshaffer
Copy link
Contributor Author

bshaffer commented Dec 5, 2018

@juan-rael done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyjacobson billyjacobson billyjacobson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bshaffer @googlebot @juan-rael @billyjacobson @raelcorrales