Skip to content

[py] add links to documentation for errors #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

[py] add links to documentation for errors #12156

merged 2 commits into from
Jun 6, 2023

Conversation

titusfortner
Copy link
Member

Description

  • Have exceptions link to documentation
  • Create custom Error for Driver Location that links to docs
  • Driver Finder gives different error message if Selenium Manager code errors
  • SeleniumManager throws WebDriverExceptions, which are caught by DriverFinder & raised as NoSuchDriver exceptions
  • Catches additional potential exceptions in Selenium Manager

Motivation and Context

  • We want to give the user the most accurate info in their error messages when there is a problem and link to more info if necessary
  • This brings the logic in line with Java & Ruby

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.17 🎉

Comparison is base (dc9ab40) 56.35% compared to head (837fdae) 56.52%.

❗ Current head 837fdae differs from pull request most recent head 7feae33. Consider uploading reports for the commit 7feae33 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12156      +/-   ##
==========================================
+ Coverage   56.35%   56.52%   +0.17%     
==========================================
  Files          86       86              
  Lines        5432     5454      +22     
  Branches      223      223              
==========================================
+ Hits         3061     3083      +22     
  Misses       2148     2148              
  Partials      223      223              
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 64.06% <70.00%> (+0.57%) ⬆️
py/selenium/common/__init__.py 100.00% <100.00%> (ø)
py/selenium/common/exceptions.py 100.00% <100.00%> (ø)
py/selenium/webdriver/common/driver_finder.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner changed the title Python Errors & Selenium Manager [py] add links to documentation for errors Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants