Skip to content

Add the Collatz Conjecture #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 26, 2022
Merged

Add the Collatz Conjecture #1022

merged 15 commits into from
May 26, 2022

Conversation

Exortions
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everyone is familiar with the collatz conjecture. Add some explanatory comments and Wikipedia links.

@Exortions
Copy link
Contributor Author

Yep, will add those tomorrow.
For now, it's time to sleep 😅

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now broken (and I still don't see cycle detection, although this is probably not necessary considering there is no known cycle within double bounds except for (1, 2) anyways)

Co-authored-by: Rak Laptudirm <[email protected]>
@appgurueu
Copy link
Collaborator

appgurueu commented May 24, 2022

This is currently unable to disprove the Collatz conjecture as it just won't halt as it lacks cycle detection (which would have to be implemented using a hashmap); it can merely show that certain sequences don't disprove the Collatz conjecture. I suggest focusing on the sequence rather than the conjecture.

@appgurueu
Copy link
Collaborator

Still reads "collatz conjecture" in numerous places...

@Exortions
Copy link
Contributor Author

Still reads "collatz conjecture" in numerous places...

As in the comments? Or the code?

@raklaptudirm raklaptudirm added the algorithm Adds or improves an algorithm label May 26, 2022
@raklaptudirm raklaptudirm merged commit 0357a23 into TheAlgorithms:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants