-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add the Collatz Conjecture #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
333edc1
Create CollatzConjecture.js
Exortions 44cd9d5
Create CollatzConjecture.test.js
Exortions 08672d3
Update CollatzConjecture.js
Exortions bf2f446
Update CollatzConjecture.test.js
Exortions 63234cc
Rename CollatzConjecture.js to CollatzSequence.js
Exortions 364465f
Update and rename CollatzConjecture.test.js to CollatzSequence.test.js
Exortions 0f907b1
Update CollatzSequence.js
Exortions 08ccb61
Update CollatzSequence.test.js
Exortions 2cb08bc
Update CollatzSequence.test.js
Exortions 71b45ea
Fix styling errors
Exortions f019897
Add suggestion
Exortions 9c78b0c
Update CollatzSequence.js
Exortions 60404cc
Update CollatzSequence.js
Exortions 33840a7
Update comments to match the Collatz Sequence
Exortions 66c8b56
Update CollatzSequence.test.js
Exortions File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* @function collatz | ||
* @description Applies the Collatz Sequence on a specified number. | ||
* The Collatz Sequence states that every natural number will always fall in a 1, 2, 4 loop when iterated under the following function: | ||
* If the number is even, divide by 2, and if its odd, multiply it by 3 and add 1. | ||
* | ||
* @parama {Integer} n The number to apply the Collatz Sequence to. | ||
* | ||
* @return An array of steps and the final result.. | ||
* | ||
* @see [Collatz Conjecture](https://en.wikipedia.org/wiki/Collatz_conjecture) | ||
* | ||
* @example collatz(1) = { result: 1, steps: [] } | ||
* @example collatz(5) = { result: 1, steps: [16, 8, 4, 2, 1] } | ||
*/ | ||
export function collatz (n) { | ||
const steps = [] | ||
|
||
while (n !== 1) { | ||
if (n % 2 === 0) { | ||
n = n / 2 | ||
} else { | ||
n = 3 * n + 1 | ||
} | ||
|
||
steps.push(n) | ||
Exortions marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
return { result: n, steps: steps } | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { collatz } from '../CollatzSequence' | ||
|
||
describe('The Collatz Sequence', () => { | ||
it('Should be 1', () => { | ||
expect(collatz(1)).toStrictEqual({ result: 1, steps: [] }) | ||
expect(collatz(5)).toStrictEqual({ result: 1, steps: [16, 8, 4, 2, 1] }) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.