Changes for consolidation

[lvlte]

Full switch to ESM.
Remove live code examples (either convert to Jest test or leave hints as a comment).
Remove all console.log (except if encapsulated within a specific method/function).
Revise all algorithms logging results instead of returning them.
...

Fixes #720

[raklaptudirm]

Is this done? If it is not, please convert the pr to draft.

[lvlte]

Nope, there is a lot more to do... converting to draft.

[raklaptudirm]

@lvlte Please try to avoid using the jest mock functions. Remove the console logs wherever possible, and only use the mock functions where the console logs are a part of the solution.

[lvlte]

That is what I'm doing : algorithms having a print/view/display method rely on console.log, which I leave (in this case only) as a default output callback. Such callback can then be overriden by a mock function so that expected results can be checked by Jest with expect(result).toBe(something).

For logs that are used to print results on the fly as they appears (outside of a print function), I use an output array where the results are pushed, and return the output.

All other logs & live code that don't tell what result is expected are removed, and their content is left as a comment when it gives useful information.

[lvlte]

Hi @raklaptudirm and all,

This is strange, this commit 9218a5c causes the build to fail, but I don't get why.

The error says : Cannot find module '../romanToDecimal' from 'Conversions/test/RomanToDecimal.test.js'
Though the import is just import { romanToDecimal } from '../romanToDecimal'

Do you have any idea ?
On my side all tests pass, included this one.

[EDIT] : this is fixed, it was a typo (lower instead of uppercase), which on my (Windows) machine does not make a difference.

[lvlte]

It was tedious but I think I'm finally done with this PR.

[defaude]

[EDIT] : this is fixed, it was a typo (lower instead of uppercase), which on my (Windows) machine does not make a difference.

Ahh, the good old case-insensitive file system stuff 😺

[defaude]

Holy crap, you've been hella busy!!

tbh I did not review all 155 changed files thoroughly but as far as I can tell, this looks nice. 👍

[defaude]

I'd even recommend:

Fixes #720

[lvlte]

Thanks, I've added the keyword in the PR description.

[raklaptudirm]

@cclauss a review please.