fix(install): pass agent correctly to packageJson function #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#1899 - at some point the syntax changed, so we need to pass the agent differently
acburdine
force-pushed
the
fix/pkgjson-agent
branch
from
8cd86b3 to
9273f36
Compare
Member
|
Aside: should we update our E2E test to use a local proxy? |
Member
Author
hmm, possibly - i'll have to see if there's an easy way to assert in the test that traffic is actually going through the proxy |
Member
|
I can take a look after this gets merged |
Member
Author
|
tested this locally and everything looks good after fixing another location 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1899