Skip to content

fix(install): pass agent correctly to packageJson function #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acburdine merged 2 commits into from
Nov 14, 2024
Merged

fix(install): pass agent correctly to packageJson function #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9273f36
fix(install): pass agent correctly to packageJson function
acburdine Nov 12, 2024
bd4a719
fix more syntax
acburdine Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/tasks/yarn-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ const getProxyAgent = require('../utils/get-proxy-agent');

const subTasks = {
async dist(ctx) {
const proxyAgent = getProxyAgent();
const {dist, engines = {}} = await packageInfo('ghost', {
version: ctx.version,
agent: getProxyAgent()
agent: proxyAgent ? {https: proxyAgent} : false
});

const skipNodeVersionCheck = (process.env.GHOST_NODE_VERSION_CHECK === 'false');
Expand Down
3 changes: 2 additions & 1 deletion lib/utils/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ const MIN_RELEASE = '>= 1.0.0';

const utils = {
async loadVersions(includePrerelease = false) {
const proxyAgent = getProxyAgent();
const result = await packageJson('ghost', {
allVersions: true,
agent: getProxyAgent()
agent: proxyAgent ? {https: proxyAgent} : null
});
const versions = Object.keys(result.versions)
.filter(v => semver.satisfies(v, MIN_RELEASE, {includePrerelease}))
Expand Down
Loading