Rename ellipses html class to ellipsis #5882
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5882
|
@frankieroberto Going to close and re-open the PR to see if it gives me the UI to run the checks 😊 |
|
@romaricpascal did it work? |
|
@frankieroberto Not automatically, but @domoscargin saved the day 🙌🏻 |
romaricpascal
left a comment
romaricpascal
left a comment
There was a problem hiding this comment.
Singular makes more sense indeed, especially as it relates to a particular item of the pagination rather than the pagination (which may have multiple items with ellipsis).
Code change looks good, but I think we'll need a little CHANGELOG entry ("Recommended change", I think) to let people know we're moving from .govuk-pagination__item--ellipses to .govuk-pagination__item--ellipsis and they should update their code. Would you be alright drafting it @frankieroberto or would you prefer we do it?
|
@romaricpascal added a changelog entry. Let me know if you’d like to make any tweaks (or feel free to push directly to this branch). Looks like you'll need to approve the workflows again to allow them to be re-run. |
domoscargin
left a comment
domoscargin
left a comment
There was a problem hiding this comment.
Thanks, @frankieroberto - this looks good to me
|
@frankieroberto There's a small formatting error on the CHANGELOG - I think if you just move "Recommended changes" above Fixes it sorts itself out - tried pushing it myself but I don't have access. |
|
@domoscargin thanks, I think I’ve fixed that. Can you re-approve again please? I've also given you write access to our fork, I think (not sure if you have to accept the invite first). |
The param name uses `ellpisis` (singular) but the class name uses `ellipses` (plural), which is a bit confusing? This switches to using the singular for both, but also supports the plural for backwards-compatibility (could be dropped in next major release?)
domoscargin
force-pushed
the
rename-ellipses-to-ellipsis
branch
from
114680f to
ad4a266
Compare
|
Oh, Prettier, you cheeky scamp. I've edited the changelog again - should hopefully be good to go now, will just wait for the checks to complete. |
|
@domoscargin @romaricpascal thanks both! This now means our new Pagination component in NHS frontend will use the exact same HTML and classes (with a different prefix) as the GOVUK one... 😄 |
4 participants
The param name uses
ellpisis(singular) but the class name usesellipses(plural), which is a bit confusing as there’s only one ellipsis within the list item? (At least, it confused me).This switches to using the singular for both, but also supports the plural for backwards-compatibility (could be dropped in next major release?)