Skip to content

Rename ellipses html class to ellipsis #5882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domoscargin merged 2 commits into from
Oct 7, 2025
Merged

Rename ellipses html class to ellipsis #5882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ce8a7f
Rename ellipses html class to ellipsis
frankieroberto Apr 27, 2025
ad4a266
Add changelog entry
frankieroberto Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ We made these changes in the following pull requests:
- [#6264: Add media query functions](https://github.com/alphagov/govuk-frontend/pull/6264).
- [#6265: Rewrite `govuk-media-query`, remove dependency on `sass-mq`](https://github.com/alphagov/govuk-frontend/pull/#6265).

### Recommended changes

#### Rename ellipses HTML class in pagination to ellipsis

Within the pagination component, change the `govuk-pagination__item--ellipses` class to `govuk-pagination__item--ellipsis`.

We introduced this change in [pull request #5882: Rename ellipses html class to ellipsis](https://github.com/alphagov/govuk-frontend/pull/5882).

### Fixes

- [#6297: Output deprecation warning if $govuk-show-breakpoints is true](https://github.com/alphagov/govuk-frontend/pull/6297)
Expand Down
2 changes: 2 additions & 0 deletions packages/govuk-frontend/src/govuk/components/pagination/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@

// Only show first, last and non-link items on mobile
.govuk-pagination__item--current,
.govuk-pagination__item--ellipsis,
.govuk-pagination__item--ellipses,
.govuk-pagination__item:first-child,
.govuk-pagination__item:last-child {
Expand All @@ -92,6 +93,7 @@
}
}

.govuk-pagination__item--ellipsis,
.govuk-pagination__item--ellipses {
@include govuk-typography-weight-bold;
color: $govuk-secondary-text-colour;
Expand Down
2 changes: 1 addition & 1 deletion packages/govuk-frontend/src/govuk/components/pagination/template.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
{% endmacro -%}

{%- macro _pageItem(item) -%}
<li class="govuk-pagination__item {%- if item.current %} govuk-pagination__item--current{% endif %} {%- if item.ellipsis %} govuk-pagination__item--ellipses{% endif %}">
<li class="govuk-pagination__item {%- if item.current %} govuk-pagination__item--current{% endif %} {%- if item.ellipsis %} govuk-pagination__item--ellipsis{% endif %}">
{% if item.ellipsis %}
&ctdot;
{% else %}
Expand Down
2 changes: 1 addition & 1 deletion packages/govuk-frontend/src/govuk/components/pagination/template.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('Pagination', () => {
it('marks up pagination items as ellipses when specified', () => {
const $ = render('pagination', examples['with many pages'])
const $firstEllipsis = $(
'.govuk-pagination__item:nth-child(2).govuk-pagination__item--ellipses'
'.govuk-pagination__item:nth-child(2).govuk-pagination__item--ellipsis'
)

expect($firstEllipsis).toBeTruthy()
Expand Down