-
Notifications
You must be signed in to change notification settings - Fork 12k
Issue with having multiple --base-href
option. (Data path “.baseHref” should be string.)
#12948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, I have looked at this and it seems that is no longer reproducible in version 7 of the CLI. |
I think there is still an open concern here regarding the behavior in the case an option is specified two or more times. Should it error? Warn? Which of the options should be used? etc. |
In the case an option is specified two or more times. In earlier versions it used to pick the last option. which is the expected as well. |
I reported a similar issue here: #11448 |
I think I’d still prefer some type of warning though. Depending on the setup, it may not be obvious that multiple values are being passed. |
The latest v7 argument parser picks the last option. I think it was in the way yargs-parser was in v6. This issue is fixed. What remained is whether or not we should show some warning, and I think that's a generally good idea. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Command (mark with an
x
)Versions
node -> v8.11.3
npm -> v5.5.1
ng -> v6.2.7
Repro steps
I have recently upgraded to Angular 6 from Angular 5. I am having [email protected]
In my
package.json
, I have configured script "build": "ng build --prod --base-href=/my-ui/"now when I run yarn build --base-href=/my-ui-2/. resulting following error
The log given by the failure
Desired functionality
It used to work in earlier versions of angular-cli considering the last option i.e my-ui-2.
Mention any other details that might be useful
The text was updated successfully, but these errors were encountered: