Skip to content

feat(@angular/cli): add warning for overriding flags in arguments #12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Nov 16, 2018

Please review the wording of the warning. It gives something like this:

image

Fixes #12948

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you have a lint error

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Nov 19, 2018
@hansl hansl merged commit 3e9705f into angular:master Nov 20, 2018
@hansl hansl deleted the fix-12948 branch November 29, 2018 01:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with having multiple --base-href option. (Data path “.baseHref” should be string.)
3 participants