Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

@philspitler
Copy link
Contributor

When going to http://localhost:8000/app the application was failing to find the installed bower_components directory.

When running npm test I was getting the same error. I changed the reference to point to where bower installs it's components now ../app/bower_components.

An alternative would be to add a .bowerrc file and change where bower installs it's components to the root directory of the project.

@petebacondarwin
Copy link
Contributor

See #183

@petebacondarwin
Copy link
Contributor

If you ran npm install in the root folder of angular-seed then as of right now, on master, it should install the bower_components folder in the same folder. Perhaps you ran bower install angular when in the app folder?

@philspitler
Copy link
Contributor Author

Hi @petebacondarwin,

I reviewed my pull request and your comments. If I checkout the d38e348 commit (the one before your latest round of updates) and run npm install from the root directory, it was already creating my bower_components directory under the app folder. The problem I had was all the references (index.html & karma tests) pointed to it being under the root folder. I even cleared my npm cache before running it and get the same thing.

I've been snooping around for an installer slipping into the app folder before bower gets run but after about 30 minutes of poking around, I can't find it.

I am very interested to find out if you delete (because they are in the .gitignore file and would stick around) your /node_modules folder, any bower_components folder and any .bowerrc file you have and checkout the commit I listed above into it's own branch locally, then run npm install... and immediately run npm test, what you get.

  1. Where does it install the bower_components directory for you (is it under app?)

  2. Do your karma tests pass.

I get failures because just by default bower_components are getting installed into the app directory for me, yet the karma tests look for it in the root folder.

I realize your commit daf71f2 fixes this issue regardless. I am just trying to get a sanity check. Forget about the browser for now please. I believe I was doing something wrong with it failing, but do the karma tests pass or fail for you?

Thank you!

@philspitler
Copy link
Contributor Author

I sincerely apologize if I've wasted any of your time @petebacondarwin . I had a rouge .bowerrc file sitting in a parent directory of the project. I actually appreciated that the bower_components directory was supposed to be in the root of the site and not under "app". If this change was due to my mistake and that only, please roll it back. Again, I'm sorry I submitted this pull request.

@philspitler
Copy link
Contributor Author

Last I will bug you @petebacondarwin . I just saw the other issue this resolves and it sounds reasonable. I'm glad the effort you put in was not only due to my mistake of an issue. Thank you very much for all that you do on this project.

@petebacondarwin
Copy link
Contributor

@philspitler no problem. I was about to suggest a rogue .bowerrc file as this has come up before. Glad all is well for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants