Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

@petebacondarwin
Copy link
Contributor

This will help web servers who are not happy to serve up files outside
the "root" folder of the application.

This will help web servers who are not happy to serve up files outside
the "root" folder of the application.
@eddiemonge
Copy link

Funny, we did the opposite: yeoman/generator-webapp@cdc519d

@petebacondarwin
Copy link
Contributor Author

I appreciate that it is nice to have the app folder as a safe place where the developer can do their stuff. But then you do need a build process and a dist folder.

The build would move (and possibly concatenate and minify) the "needed" bower component files (many are not) and the application files in order to be served.

This is a valid process but since angular-seed is minimal and has no build process it makes more sense to keep things that are to be served in a single folder. In the case of angular-seed, the app folder itself only contains the index files and then a bunch of folders where you do actually do your stuff, such as js, css, img, partials.

The only real concern I have is that we are modifying the "default" bower installation location, which is always going to add confusion.

Despite all this, I think it is reasonable to move the bower_components into app for the purposes of angular-seed. But it should be well documented in the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants