Skip to content

Conversation

@eyoeldefare
Copy link
Contributor

fixes issue #3290. Its complaining because some of the interfaces are not extended with the expected generic type T when they're expecting a type of T.

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

)

fixes issue angular#3290. Its complaining because some of the interfaces are not extended with the expected generic type T when they're expecting a type of T.
Copy link

@BoltzBit BoltzBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!! don't forget to add a reviewer!

@Dyllanjrusher
Copy link

Hey, Thanks for your contribution! It looks like you haven't added a reviewer with write access. Can you do so to get this in? It looks like the issue is still holding quite a few folks up, including myself. I'll check in in a few days but will unfortunately have to resubmit your changes if this doesn't get in soon.

@vytautas-pranskunas-
Copy link

watching

Copy link

@JSponaugle JSponaugle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly What is required to fix this issue

@drewzh
Copy link

drewzh commented Feb 2, 2023

Just to note to anyone watching - this only seems to apply to the compat layer. If using the new syntax (which rather annoyingly doesn't seem to be well documented), you won't face this issue. At least this is my experience having had the issue and then subsequently refactoring to remove /compat/ layers and fixing the issue as a result.

@pbrennand-francis
Copy link

Who has write access who can approve this as a reviewer? Seems to be a simple fix to something affecting a number of people.

@davideast davideast enabled auto-merge (squash) June 23, 2023 15:05
@davideast davideast self-requested a review June 23, 2023 15:06
@davideast davideast self-assigned this Jun 23, 2023
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyoeldefare Thank you so much for this contribution and apologies for the last response from us. I'm working on cleaning up this repository. There have been a ton of PRs submitted to address this issue so I'm going through them all now and I'm not currently sure which one will get submitted due to the constant running of the CI processes but I promise it will get fixed!

@davideast davideast merged commit 450ee6e into angular:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.