-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: fixes generic type exception in firestore interfaces: (#3290) #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
) fixes issue angular#3290. Its complaining because some of the interfaces are not extended with the expected generic type T when they're expecting a type of T.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!! don't forget to add a reviewer!
|
Hey, Thanks for your contribution! It looks like you haven't added a reviewer with write access. Can you do so to get this in? It looks like the issue is still holding quite a few folks up, including myself. I'll check in in a few days but will unfortunately have to resubmit your changes if this doesn't get in soon. |
|
watching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly What is required to fix this issue
|
Just to note to anyone watching - this only seems to apply to the compat layer. If using the new syntax (which rather annoyingly doesn't seem to be well documented), you won't face this issue. At least this is my experience having had the issue and then subsequently refactoring to remove /compat/ layers and fixing the issue as a result. |
|
Who has write access who can approve this as a reviewer? Seems to be a simple fix to something affecting a number of people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eyoeldefare Thank you so much for this contribution and apologies for the last response from us. I'm working on cleaning up this repository. There have been a ton of PRs submitted to address this issue so I'm going through them all now and I'm not currently sure which one will get submitted due to the constant running of the CI processes but I promise it will get fixed!
fixes issue #3290. Its complaining because some of the interfaces are not extended with the expected generic type T when they're expecting a type of T.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Code sample