Skip to content

fix: fixes generic type exception in firestore interfaces: (#3290) #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix: fixes generic type exception in firestore interfaces: (#3290) #3304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af93f98
fix: fixes generic type exception in firestore interfaces: (#3290)
eyoeldefare Jan 4, 2023
e92a820
Merge branch 'master' into issue-#3290
davideast Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/compat/firestore/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type Query<T = DocumentData> = firebase.firestore.Query<T>;
export type SetOptions = firebase.firestore.SetOptions;
export type DocumentData = firebase.firestore.DocumentData;

export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot {
export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot<T> {
readonly exists: true;
data(options?: SnapshotOptions): T;
}
Expand All @@ -26,15 +26,15 @@ export interface DocumentSnapshotDoesNotExist extends firebase.firestore.Documen

export type DocumentSnapshot<T> = DocumentSnapshotExists<T> | DocumentSnapshotDoesNotExist;

export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot {
export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot<T> {
data(options?: SnapshotOptions): T;
}

export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot {
export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot<T> {
readonly docs: QueryDocumentSnapshot<T>[];
}

export interface DocumentChange<T> extends firebase.firestore.DocumentChange {
export interface DocumentChange<T> extends firebase.firestore.DocumentChange<T> {
readonly doc: QueryDocumentSnapshot<T>;
}

Expand Down