Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/amazon-ec2-instance-selector
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.3
Choose a base ref
...
head repository: aws/amazon-ec2-instance-selector
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.0
Choose a head ref
  • 9 commits
  • 24 files changed
  • 6 contributors

Commits on Jul 26, 2022

  1. CLI Instance Sorting (#146)

    * created sorting system based on json pathing
    
    * incorporated sorting system into CLI
    
    * added shorthand sorting fields
    
    * Revert "Handle pricing api change in aws-sdk-go 1.44.46 (#145)
    
    * Revert "Handle pricing api change in aws-sdk-go 1.44.46 (#140)"
    
    This reverts commit cec208c.
    
    * Update aws-sdk-go to v1.44.59
    
    * added sorting example and new help printout to readme
    
    * added jsonpath library license to third party licenses
    
    * changed sorting to use sort.Slice()
    
    * removed need for $ in json path
    
    * shortened sort-by flag description and updated readme
    
    * early sort return for empty and 1 element lists
    
    * added sorter tests
    
    * fixed typos
    
    * reduced scope of if statement in main
    
    Co-authored-by: Brandon Wagner <[email protected]>
    
    * simplified call to sort instances
    
    * modified tests for new sorting interface
    
    * fixed comment typo
    
    * refactored sorting keys map
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    Co-authored-by: Ciprian Hacman <[email protected]>
    Co-authored-by: Brandon Wagner <[email protected]>
    4 people authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    0256428 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Interactive output format (#149)

    * imported bubble tea table
    
    * created bubbletea.go in cli directory
    
    * all bubble tea columns populated
    
    * added controls
    
    * improved controls printout in footer
    
    * created instance type view
    
    * cleaned up mod file
    
    * fixed sort bug in CLI usage
    
    * cleaned up table creation code + vertical scaling
    
    * updated third party licenses
    
    * updated --help printout in readme
    
    * rename headerPadding variable
    
    * added bubble tea tests
    
    * renamed column header constants
    
    * changed bubble tea flag to table-interactive
    
    * interactive table hydrates pricing caches
    
    * changed bubble tea flag to 'interactive'
    
    * sort in all cases
    
    * de-dupe logic in TableOutputWide and bubble tea row/column creation
    
    * updated bubble tea tests
    
    * added dynamic column widths
    
    * fixed extra () in main
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    e4364b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. fix pricing sync issue (#150)

    * fix pricing sync with mutex on refresh
    
    * expire cache items on load
    bwagner5 authored Aug 3, 2022
    Configuration menu
    Copy the full SHA
    a07cb5a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Verbose View for Interactive Output (#151)

    * added verbose view to interactive output
    
    * removed useless statement
    
    * updated verbose view controls
    
    * added 'none' to missing gpuinfo
    
    * updated example table-wide printouts in readme
    
    * fixed width resizing bug with text wrapping
    
    * moved views into own files
    
    * fixed bubble tea tests
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Aug 4, 2022
    Configuration menu
    Copy the full SHA
    218d13f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. fixed eks testing bug (#153)

    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    98c3555 View commit details
    Browse the repository at this point in the history
  2. Interactive table sorting, trimming, and filtering (#152)

    * implemented filtering
    
    * styled filter text input
    
    * fixed bug with filtering and then going to verbose view
    
    * fixed bug with expanding with no rows selected
    
    * working trim feature
    
    * fixed trim while filtering bug
    
    * moved sorting shorthands to sorter.go
    
    * created sorting view (Non fuctional)
    
    * fixed row selection toggle
    
    * added sorting by json path
    
    * added sorting by shorthand values
    
    * added sort direction toggle
    
    * updated third party licenses
    
    * moved all sorting constants to sorter.go
    
    * removed unecessary print in sortingView view()
    
    * renamed initSortingView to initSortingModel
    
    * use 'esc' instead of 'e' to exit verbose view
    
    * Added interactive output demo to readme
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    adc1627 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. fixed interactive table resizing bug (#154)

    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6e75d52 View commit details
    Browse the repository at this point in the history
  2. use-go-proxy (#156)

    bwagner5 authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    dcdd989 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e422d0 View commit details
    Browse the repository at this point in the history
Loading