This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Create login shell with coder sh #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a shell, we should use "exec -a" to set argv[0] to the basename of the command being run, prefixing a hyphen. This is how su --login creates login shells: it runs /bin/bash as "-bash", causing bash to execute .bash_profile, etc. We change the use of awk to cut, since cut is part of coreutils and thus more likely to be installed than gawk. We also pass the uid (from "id -u") instead of username to getent.
|
This pull request has been linked to Clubhouse Story #418: Use a login shell for terminals. |
kylecarbs
approved these changes
Jan 22, 2021
cmoog
approved these changes
Jan 22, 2021
|
@jawnsy no need to use a fork. I think you should have the proper perms to push to a branch in |
Haha I like the forking workflow, though 😁 |
jawnsy
added a commit
that referenced
this pull request
Jan 24, 2021
This addresses a regression introduced by #224. POSIX sh does not define arguments to the exec built-in, resulting in an error when using 'exec -a' to set the process name (argv[0]). This change executes /bin/bash instead of sh, and also changes to use 'exec -l', which automatically handles the hyphen prefix required to trigger login shell behavior. This also explicitly runs /bin/sh, aligning the behavior of "coder sh" and the frontend Terminal application.
jawnsy
added a commit
that referenced
this pull request
Jan 25, 2021
This addresses a regression introduced by #224. POSIX sh does not define arguments to the exec built-in, resulting in an error when using 'exec -a' to set the process name (argv[0]). This change executes /bin/bash instead of sh, and also changes to use 'exec -l', which automatically handles the hyphen prefix required to trigger login shell behavior. This also explicitly runs /bin/sh, aligning the behavior of "coder sh" and the frontend Terminal application.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a shell, we should use "exec -a" to set argv[0]
to the basename of the command being run, prefixing a hyphen.
This is how su --login creates login shells: it runs /bin/bash
as "-bash", causing bash to execute .bash_profile, etc.
We change the use of awk to cut, since cut is part of coreutils
and thus more likely to be installed than gawk. We also pass the
uid (from "id -u") instead of username to getent.