This repository was archived by the owner on Aug 30, 2024. It is now read-only.
fix: Force bash for non-standard flags to exec #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a regression introduced by #224. POSIX
sh
does not define arguments to theexec
built-in, resulting in an error when usingexec -a
to set the process name (argv[0]
).This change executes
/bin/bash
instead ofsh
, and also changes to useexec -l
, which automatically handles the hyphen prefix required to trigger login shell behavior.This also explicitly runs
/bin/sh
, aligning the behavior ofcoder sh
and the frontend Terminal application.Tested this using Arch Linux (enterprise-dev image) as well as the base Debian image from DockerHub.