This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Validate hostname, name, and cluster address on wsp create #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
force-pushed
the
wsp-create-validation
branch
from
38cb952 to
a08bfa6
Compare
cmoog
reviewed
Mar 10, 2021
internal/cmd/providers.go
Outdated
|
|
||
| cmd.Flags().StringVar(&name, "name", "", "workspace provider name") | ||
| cmd.Flags().StringVar(&hostname, "hostname", "", "workspace provider hostname") | ||
| cmd.Flags().StringVar(&clusterAddress, "clusterAddress", "", "kubernetes cluster apiserver endpoint") |
There was a problem hiding this comment.
I think we've been doing cluster-address
cmoog
reviewed
Mar 10, 2021
internal/cmd/providers.go
Outdated
| cmd := &cobra.Command{ | ||
| Use: "create [workspace_provider_name]", | ||
| Use: "create --name=[name] --hostname=[hostname] --clusterAddress=[clusterAddress]", |
There was a problem hiding this comment.
for consistency we may want to do name as a required positional argument, similar to coder envs create
cmoog
approved these changes
Mar 10, 2021
f0ssel
force-pushed
the
wsp-create-validation
branch
from
0b54f02 to
710e3cf
Compare
deansheather
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must be merged before https://github.com/cdr/m/pull/7417