Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Validate hostname, name, and cluster address on wsp create #277

Merged
merged 3 commits into from
Mar 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion coder-sdk/workspace_providers.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ const (
WorkspaceProviderReady WorkspaceProviderStatus = "ready"
)

// WorkspaceProviderType represents the type of workspace provider.
type WorkspaceProviderType string

// Workspace Provider types.
const (
WorkspaceProviderKubernetes WorkspaceProviderType = "kubernetes"
)

// WorkspaceProviderByID fetches a workspace provider entity by its unique ID.
func (c *DefaultClient) WorkspaceProviderByID(ctx context.Context, id string) (*KubernetesProvider, error) {
var wp KubernetesProvider
Expand All @@ -63,7 +71,10 @@ func (c *DefaultClient) WorkspaceProviders(ctx context.Context) (*WorkspaceProvi

// CreateWorkspaceProviderReq defines the request parameters for creating a new workspace provider entity.
type CreateWorkspaceProviderReq struct {
Name string `json:"name"`
Name string `json:"name"`
Type WorkspaceProviderType `json:"type"`
Hostname string `json:"hostname"`
ClusterAddress string `json:"cluster_address"`
}

// CreateWorkspaceProviderRes defines the response from creating a new workspace provider entity.
Expand Down
24 changes: 19 additions & 5 deletions internal/cmd/providers.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package cmd
import (
"fmt"

"cdr.dev/coder-cli/internal/x/xcobra"

"github.com/spf13/cobra"
"golang.org/x/xerrors"

"cdr.dev/coder-cli/coder-sdk"
"cdr.dev/coder-cli/internal/x/xcobra"
"cdr.dev/coder-cli/pkg/clog"
"cdr.dev/coder-cli/pkg/tablewriter"
)
Expand All @@ -29,13 +30,18 @@ func providersCmd() *cobra.Command {
}

func createProviderCmd() *cobra.Command {
var (
hostname string
clusterAddress string
)
cmd := &cobra.Command{
Use: "create [workspace_provider_name]",
Short: "create a new workspace provider.",
Use: "create [name] --hostname=[hostname] --clusterAddress=[clusterAddress]",
Args: xcobra.ExactArgs(1),
Short: "create a new workspace provider.",
Long: "Create a new Coder workspace provider.",
Example: `# create a new workspace provider in a pending state
coder providers create my-new-workspace-provider`,

coder providers create my-provider --hostname=https://provider.example.com --cluster-address=https://255.255.255.255`,
RunE: func(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()

Expand All @@ -46,7 +52,10 @@ coder providers create my-new-workspace-provider`,

// ExactArgs(1) ensures our name value can't panic on an out of bounds.
createReq := &coder.CreateWorkspaceProviderReq{
Name: args[0],
Name: args[0],
Type: coder.WorkspaceProviderKubernetes,
Hostname: hostname,
ClusterAddress: clusterAddress,
}

wp, err := client.CreateWorkspaceProvider(ctx, *createReq)
Expand All @@ -63,6 +72,11 @@ coder providers create my-new-workspace-provider`,
return nil
},
}

cmd.Flags().StringVar(&hostname, "hostname", "", "workspace provider hostname")
cmd.Flags().StringVar(&clusterAddress, "cluster-address", "", "kubernetes cluster apiserver endpoint")
_ = cmd.MarkFlagRequired("hostname")
_ = cmd.MarkFlagRequired("cluster-address")
return cmd
}

Expand Down