Skip to content

Windows run #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 13, 2020
Merged

Windows run #259

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6bafe24
WIP: fix extension to run on windows computers
argemiront Apr 13, 2020
2c497e7
parse version on windows
ShMcK Apr 13, 2020
c63ef14
update package versions
argemiront Apr 13, 2020
b1d32cd
Add readonly - fix eslint
argemiront Apr 13, 2020
7c278f7
change the import for Windows
argemiront Apr 13, 2020
454ea9d
Add darwin as possible OS to ts
argemiront Apr 13, 2020
f29d40d
Temp fix for WORKSPACE_ROOT on Windows
argemiront Apr 13, 2020
53dde7a
fix the Workspace path issue
argemiront Apr 13, 2020
9f4f66e
Merge branch 'master' into windows-run
argemiront Apr 13, 2020
9ec63c8
prepare 0.2.3 release with notes
ShMcK Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the Workspace path issue 
Signed-off-by: argemiront <[email protected]>
  • Loading branch information
@argemiront
argemiront committed Apr 13, 2020
commit 53dde7a768b9b353864b94140250e3ca05dced23
7 changes: 1 addition & 6 deletions src/services/workspace/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,5 @@ export const getWorkspaceRoot = (): string => {
// for simplicity, assume the first is the active workspace
const workspaceRoot: vscode.WorkspaceFolder = workspaceRoots[0]

// Remove leading / on windows machines. Temp solution
if (env.OS_PLATFORM === 'win32') {
return workspaceRoot.uri.path.substr(1)
}

return workspaceRoot.uri.path
return workspaceRoot.uri.fsPath
}