Skip to content

Windows run #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 13, 2020
Merged

Windows run #259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6bafe24
WIP: fix extension to run on windows computers
argemiront Apr 13, 2020
2c497e7
parse version on windows
ShMcK Apr 13, 2020
c63ef14
update package versions
argemiront Apr 13, 2020
b1d32cd
Add readonly - fix eslint
argemiront Apr 13, 2020
7c278f7
change the import for Windows
argemiront Apr 13, 2020
454ea9d
Add darwin as possible OS to ts
argemiront Apr 13, 2020
f29d40d
Temp fix for WORKSPACE_ROOT on Windows
argemiront Apr 13, 2020
53dde7a
fix the Workspace path issue
argemiront Apr 13, 2020
9f4f66e
Merge branch 'master' into windows-run
argemiront Apr 13, 2020
9ec63c8
prepare 0.2.3 release with notes
ShMcK Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add readonly - fix eslint 
Signed-off-by: argemiront <[email protected]>
  • Loading branch information
@argemiront
argemiront committed Apr 13, 2020
commit b1d32cde8ee9b080d84655316a6bb2f83750bd57
2 changes: 1 addition & 1 deletion src/actions/utils/openFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const openFiles = async (files: string[]) => {
}
for (const filePath of files) {
try {
const workspaceFolders: vscode.WorkspaceFolder[] | undefined = vscode.workspace.workspaceFolders
const workspaceFolders: readonly vscode.WorkspaceFolder[] | undefined = vscode.workspace.workspaceFolders
if (!workspaceFolders || !workspaceFolders.length) {
throw new Error('No workspace directory. Open a workspace directory and try again')
}
Expand Down
2 changes: 1 addition & 1 deletion src/services/workspace/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const checkWorkspaceEmpty = async () => {

// capture the workspace root to use the users dirname in processes
export const getWorkspaceRoot = (): string => {
const workspaceRoots: vscode.WorkspaceFolder[] | undefined = vscode.workspace.workspaceFolders
const workspaceRoots: readonly vscode.WorkspaceFolder[] | undefined = vscode.workspace.workspaceFolders
if (!workspaceRoots || !workspaceRoots.length) {
// no workspace root
return ''
Expand Down