Skip to content

BUILTIN_LED should be LED_BUILTIN #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SukkoPera opened this issue Feb 2, 2016 · 5 comments
Closed

BUILTIN_LED should be LED_BUILTIN #1555

SukkoPera opened this issue Feb 2, 2016 · 5 comments

Comments

@SukkoPera
Copy link

Arduino's macro that holds the number of the built-in led in boards is LED_BUILTIN. For some reason, this core uses BUILTIN_LED, leading to unportable code.

See: https://www.arduino.cc/en/Reference/Constants
@tuxedo0801
Copy link
Contributor

I also stumbled on this.

Is there a reason why the macro does not match?

@tuxedo0801
Copy link
Contributor

Added a PR for this: #1556

@SukkoPera
Copy link
Author

Well done :)

@tuxedo0801
Copy link
Contributor

@SukkoPera
Please close, PR #1556 is been merged.

@SukkoPera
Copy link
Author

Ok, thanks. I'm not really for keeping both macros, but fair enough.

fliphess added a commit to fliphess/esp8266_alarm_display that referenced this issue Jun 20, 2018
@fliphess
https://github.com/esp8266/Arduino/issues/1555
c5f2f03
r41d added a commit to r41d/esp-mqtt-rgb-led that referenced this issue Aug 8, 2018
@r41d
BUILTIN_LED was deprecated, it is now LED_BUILTIN
0ca00bc 
see esp8266/Arduino#1555
@r41d r41d mentioned this issue Aug 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SukkoPera @tuxedo0801