PR for issue #1555: change BUILTIN_LED to LED_BUILTIN #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxedo0801
changed the title
|
I'd vote for keeping BUILTIN_LED defined in pins_arduino.h, alongside with LED_BUILTIN. |
|
Having both would be OK for me. I will update the PR accordingly. |
|
now both variants are included. ESP style and Arduino style LED_BUILTIN |
igrr
pushed a commit
that referenced
this pull request
Feb 4, 2016
keep arduino incompatible BUILTIN_LED (+22 squashed commits) [e124f9c] keep arduino incompatible BUILTIN_LED [18dab66] keep arduino incompatible BUILTIN_LED [0095de6] keep arduino incompatible BUILTIN_LED [cca2714] keep arduino incompatible BUILTIN_LED [ff62bfb] keep arduino incompatible BUILTIN_LED [fd6f7c0] keep arduino incompatible BUILTIN_LED [220b02a] keep arduino incompatible BUILTIN_LED [b871b1b] keep arduino incompatible BUILTIN_LED [1d97cac] keep arduino incompatible BUILTIN_LED [ebc2667] changed BUILTIN_LED to LED_BUILTIN [7008a27] changed BUILTIN_LED to LED_BUILTIN [cf3f6da] changed BUILTIN_LED to LED_BUILTIN [5e11c43] changed BUILTIN_LED to LED_BUILTIN [8645bd5] changed BUILTIN_LED to LED_BUILTIN [faae742] changed BUILTIN_LED to LED_BUILTIN [df2659b] changed BUILTIN_LED to LED_BUILTIN [1eb74d5] changed BUILTIN_LED to LED_BUILTIN [fb9e977] changed BUILTIN_LED to LED_BUILTIN [b735737] changed BUILTIN_LED to LED_BUILTIN [d0557dd] changed BUILTIN_LED to LED_BUILTIN [a25e4aa] changed BUILTIN_LED to LED_BUILTIN [7865ace] changed BUILTIN_LED to LED_BUILTIN
|
Squashed and merged in 573a0fb, thanks. |
narongrat
added a commit
to narongrat/Arduino
that referenced
this pull request
Feb 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed all occurrences of BUILTIN_LED to arduino like LED_BUILTIN.
I hope I missed nothing ...